Some refactoring after static code analysis

This commit is contained in:
2026-02-08 12:48:29 +01:00
parent bdaaf1fe9f
commit 69ef2c6904
43 changed files with 3244 additions and 1097 deletions

View File

@@ -8,33 +8,33 @@ END_VAR
VAR_OUTPUT
END_VAR
VAR
_xOpenDoor1 AT %Q* : BOOL;
_xOpenDoor2 AT %Q* : BOOL;
xOpenDoor1 AT %Q* : BOOL;
xOpenDoor2 AT %Q* : BOOL;
_xCloseDoor1 AT %Q* : BOOL;
_xCloseDoor2 AT %Q* : BOOL;
xCloseDoor1 AT %Q* : BOOL;
xCloseDoor2 AT %Q* : BOOL;
// Chamber is the big cylinder not the door
_xOpenChamber1 AT %Q* : BOOL;
_xOpenChamber2 AT %Q* : BOOL;
xOpenChamber1 AT %Q* : BOOL;
xOpenChamber2 AT %Q* : BOOL;
_xCloseChamber1 AT %Q* : BOOL;
_xCloseChamber2 AT %Q* : BOOL;
xCloseChamber1 AT %Q* : BOOL;
xCloseChamber2 AT %Q* : BOOL;
END_VAR
]]></Declaration>
<Implementation>
<ST><![CDATA[IF xOpenChambers THEN
_xOpenDoor1 := TRUE;
_xOpenDoor2 := TRUE;
xOpenDoor1 := TRUE;
xOpenDoor2 := TRUE;
_xCloseDoor1 := FALSE;
_xCloseDoor2 := FALSE;
xCloseDoor1 := FALSE;
xCloseDoor2 := FALSE;
ELSE
_xOpenDoor1 := FALSE;
_xOpenDoor2 := FALSE;
xOpenDoor1 := FALSE;
xOpenDoor2 := FALSE;
_xCloseDoor1 := TRUE;
_xCloseDoor2 := TRUE;
xCloseDoor1 := TRUE;
xCloseDoor2 := TRUE;
END_IF
// Call base sm